Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume API uses Fog::Compute::OpenStack::NotFound exception class #48

Open
plribeiro3000 opened this issue Mar 10, 2016 · 1 comment
Open

Comments

@plribeiro3000
Copy link
Member

lib/fog/openstack/volume.rb#L177 has what is probably just a copy-paste error:

rescue Excon::Errors::HTTPStatusError => error
  raise case error
  when Excon::Errors::NotFound
    Fog::Compute::OpenStack::NotFound.slurp(error)
  else
    error
  end

That custom exception class should be Fog::Volume::OpenStack::NotFound.(with Volume instead of Compute). Since that class already exists and is used in a few other places, I don't see an easy way to fix that in a backwards-compatible way. So it should at least be noted and fixed when backwards compatibility is broken the next time.

Original issue opened by @majewsky at fog/fog#3618

@plribeiro3000
Copy link
Member Author

cc/ @majewsky @TerryHowe @geemus @MaPoCaCe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant