Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpinned version of fog-xenserver breaks with older ruby versions #4012

Closed
powellchristoph opened this issue Sep 21, 2018 · 10 comments
Closed
Labels

Comments

@powellchristoph
Copy link

Greetings,

It looks like a recent release of fog-xenserver has a new dep on xmlrpc which requires Ruby version >= 2.3.

Would it be possible to add some version constraints?
https://github.com/fog/fog/blob/v1.37.0/fog.gemspec#L73

# /opt/chef/embedded/bin/gem install fog --no-rdoc --no-ri -v "1.37.0"
ERROR:  Error installing fog:
    xmlrpc requires Ruby version >= 2.3.

ruby: 2.1.9p490 (2016-03-30 revision 54437) [x86_64-linux]

fog/fog-xenserver#74

geemus added a commit that referenced this issue Sep 24, 2018
@plribeiro3000
Copy link
Member

Hmmmm. Can't you use a recent version of fog? Like 1.42.1?

This one is to old and the problem you describe should be fixed at the latest.

@reist
Copy link

reist commented Sep 25, 2018

I just encountered the same issue. Using fog 1.42.1 is not enough, as it pulls in the latest fog-xenserver, which will try to install xmlrpc anyway.
There's also a problem with fog-openstack, which needs Ruby>2.2.0 now.
The way I install fog after these releases on 2.1:
gem install --no-ri --no-rdoc fog-core:1.45.0 fog-openstack:0.1.24 fog-xenserver:0.3.0 fog:1.42.1

@plribeiro3000
Copy link
Member

plribeiro3000 commented Sep 25, 2018

@geemus Maybe is time for us to start dropping the dependencies on fog > 2?

Ok. So i believe a new patch version on fog will be needed, locking all dependency versions. WDYT @geemus ?

@geemus
Copy link
Member

geemus commented Sep 26, 2018

@plribeiro3000 yeah, locking may be easiest for now, but dropping would be better in the longer term.

@geemus
Copy link
Member

geemus commented Sep 26, 2018

@reist is that the newest openstack that will work? (it's a rather old version)

@reist
Copy link

reist commented Sep 26, 2018

@geemus Maybe 0.1.25 will also work with Ruby 2.1, but that's it, because immediately after the spec was changed to this:
spec.required_ruby_version = '>= 2.2.0'

@geemus
Copy link
Member

geemus commented Sep 26, 2018

One last avenue, as I'm a bit concerned about breakage here. How many providers does chef actually utilize? Could we start moving toward individual gem requires, and away from blanket fog require instead?

@stale
Copy link

stale bot commented Nov 25, 2018

This issue has been automatically marked stale due to inactivity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 25, 2018
@stale
Copy link

stale bot commented Jan 25, 2019

This issue has been automatically marked stale due to inactivity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 25, 2019
@stale stale bot closed this as completed Feb 1, 2019
@plribeiro3000
Copy link
Member

I will leave this issue closed since we did not get feedback.

Feel free to comment back or reopen if you want/need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants