[rackspace|identity] Better checking around hash/array responses. #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of simply checking for the existence of a key in Identity API responses, this checks the type of the expected response. This should be a less fragile way of handling hash/array responses.
|
LGTM |
brianhartsock
added a commit
that referenced
this pull request
Jun 27, 2012
…e_checks [rackspace|identity] Better checking around hash/array responses.
|
Thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the Identity API request methods simply checked for the existence of a key in the response to determine whether a single object or an array was returned. Using type checking should be a less fragile approach. Tests still pass.
/cc @brianhartsock