Enable AWS spot requests in a VPC by specifying subnet_id #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'Type' => request_type, | ||
| 'ValidFrom' => valid_from, | ||
| 'ValidUntil' => valid_until } | ||
| options.delete_if {|key, value| value.nil?} | ||
|
|
||
| # If subnet is defined then this is a Virtual Private Cloud. |
There was a problem hiding this comment.
Unless I'm mistaken, I don't think this mutual exclusion is still required. See: #786 Please let me know if that is not accurate in this case, but we should allow both if it does work.
|
@turley Other than that one spot it looks great, thanks! |
|
@geemus I believe that pull request (#786) was never merged because indeed, the mutual exclusion IS required. You can, however, use security_group_ids and subnet_id without any problem. FWIW, I actually did try this without the check and got a response basically explaining that the two can't both be set. |
|
@turley well played, my brain betrays me again. I knew there was that ticket but I guess I forgot the outcome, thanks for helping me out with that. |
geemus
added a commit
that referenced
this pull request
Aug 27, 2012
Enable AWS spot requests in a VPC by specifying subnet_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the "subnet_id" attribute for spot requests so they can be created in a VPC.