Rackspace Cloud Block Storage models have the potential to create unintended resources #1404
Conversation
…Rackspace::BlockStorage::Snapshot to skip creating cloud reources if identity was already set Fixes fog#1402
|
@krames - For the sake of consistency with other things in fog this should probably raise an error (rather than returning true) for saves that fail. I think this better communicates what is up and avoids any confusion about save and update being equivalent. See: https://github.com/fog/fog/blob/master/lib/fog/rackspace/models/compute/server.rb#L69 Thoughts? |
|
@krames - also, looks like one of your other commits and this one conflict, so a rebase would be awesome. Thanks! |
|
No problem! I will update it to throw an error and rebase the code. |
…og::Rackspace::BlockStorage::Snapshot to throw an exception if the identity attribute is set per geemus; rebased code to latest master
|
This should be good to go. @brianhartsock can you review and merge this one for me? Thanks! |
|
Hmm. I wish the API for block and compute had a more well defined "update" (like https://github.com/fog/fog/blob/master/lib/fog/rackspace/models/load_balancers/load_balancer.rb#L166) but they don't... With that said, LGTM |
Rackspace Cloud Block Storage models have the potential to create unintended resources
This pull request fixes #1402
The save method in both Fog::Rackspace::BlockStorage::Volume and Fog::Rackspace::BlockStorage::Snapshot create new cloud resources every time they are called. This has the potential to create unintended resources.