Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rackspace|lb] Add support for timeout attribute #1830

Merged
merged 1 commit into from May 28, 2013

Conversation

decklin
Copy link
Member

@decklin decklin commented May 23, 2013

I needed support for this attribute. Per the API docs it is not included in individual LB responses and the "detail" listing but not the regular listing. Added it to relevant tests.

This is pretty trivial and I can merge if no one has any issues but since I haven't touched Fog in a while I figure it'd be good to let someone look over it.

@geemus
Copy link
Member

geemus commented May 23, 2013

@decklin - thanks!

@krames - could you review? Thanks!

@krames
Copy link
Member

krames commented May 23, 2013

@decklin Thanks for the contribution! (And the tests!!!)

I did notice that you made timeout a required attribute for the update. According to the REST docs, the timeout attribute as well as the other attributes in the update are optional.

http://docs.rackspace.com/loadbalancers/api/v1.0/clb-devguide/content/Update_Load_Balancer_Attributes-d1e1812.html

I wonder what happens if you don't specify a timeout value on creation and then update the load balancer without specifying a timeout value. I suspect it would keep it's default value, but let me double check.

Other than that it looks good to me.

@decklin
Copy link
Member Author

decklin commented May 28, 2013

I took a look at this, and the (default) timeout value comes back with the newly created LB whether specified or not. So, modifying another attribute and saving it will work (and explicitly include the timeout in that request).

@krames
Copy link
Member

krames commented May 28, 2013

Thanks for looking into that, it was my only concern. I am going to go ahead with the merge.

Thanks again for the contribution!

krames pushed a commit that referenced this pull request May 28, 2013
[rackspace|lb] Add support for timeout attribute
@krames krames merged commit c204dbd into fog:master May 28, 2013
@decklin decklin deleted the rs-lb-timeout branch May 28, 2013 19:44
@geemus
Copy link
Member

geemus commented May 29, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants