Minitest picks up tests in provider modules #2755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! - This is what CI is useful for. So the failure is because fog does magic in the background and loads my system Underlying issue (#1390) is that Fog.credentials is a global that loads itself based on the environment, so my dev seup or the Travis CI box which is brittle for unit tests. So the problem is actually in my new provider test which this exposes. |
This isolates the tests from the values in `Fog.credentials` which is based on the contents of `~/.fog` Underlying problem is that the code (and many others) rely on the Fog global making it too tightly coupled to the environment hence having to stub. Full issue: #1390 This will probably be a repeating pattern we need to work on to DRY up so every test from every provider doesn't include this setup workaround.
tokengeek
added a commit
that referenced
this pull request
Mar 13, 2014
Minitest picks up tests in provider modules
|
Thanks! On Thu, Mar 13, 2014 at 6:14 AM, Paul Thornthwaite <notifications@github.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the pattern we match tests to run under minitest.
This will run anything under
testorproviders/*/testso includes tests written by providers.