Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google|compute] Add Addresses support #2846

Merged
merged 1 commit into from Apr 11, 2014
Merged

[google|compute] Add Addresses support #2846

merged 1 commit into from Apr 11, 2014

Conversation

frodenas
Copy link
Contributor

  • Add "Addresses" model and collection
  • Add "list_aggregated_addresses" request
  • Modify "insert" request to allow "description" property

@frodenas
Copy link
Contributor Author

@icco Another one to review please :) This one depends on #2839

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 061a7ae on frodenas:gce_addresses into eaf7a32 on fog:master.

- Add "Addresses" model and collection
- Add "list_aggregated_addresses" request
- Modify "insert" request to allow "description" property
@frodenas
Copy link
Contributor Author

Rebased and added synchronous deletes.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 0a05ba6 on frodenas:gce_addresses into b7675cd on fog:master.

icco added a commit that referenced this pull request Apr 11, 2014
[google|compute] Add Addresses support
@icco icco merged commit bba773e into fog:master Apr 11, 2014
@icco
Copy link
Member

icco commented Apr 11, 2014

Awesome! Thanks again for all of these.

@geemus
Copy link
Member

geemus commented Apr 11, 2014

Thanks!

On Fri, Apr 11, 2014 at 4:25 AM, Nat Welch notifications@github.com wrote:

Awesome! Thanks again for all of these.

Reply to this email directly or view it on GitHubhttps://github.com//pull/2846#issuecomment-40185831
.

@frodenas frodenas deleted the gce_addresses branch April 11, 2014 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants