Fix path with contained query #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Query can be a hash also, actually, and I think in this case it might be clearer to do so. I'll include examples inline for clarity. What do you think? Thanks! |
| if attribute | ||
| path = "images/detail?#{attribute}=#{URI::encode(query)}" | ||
| query = "#{attribute}=#{URI::encode(query)}" |
There was a problem hiding this comment.
So this might be { attribute => URI::encode(query) }.
|
I misunderstood on first read through. I'll test the hash syntax, seems nicer. |
Query inside path is not allowed, it should be under separate key :query. Putting query inside path leads to error: URI::InvalidComponentError Exception: bad component(expected absolute path component): /v1.1/images/detail?limit=20 Caused most probably by this comparison: URI::parser.regexp[:ABS_PATH] !~ v
Ladas
force-pushed
the
openstack_fix_list_public_image_detailed
branch
from
c89c909
to
cc04c7f
Compare
|
Cool, seems like the hash syntax works. Thanks for pointing that out. |
|
Looks good, thanks! |
geemus
added a commit
that referenced
this pull request
Dec 11, 2014
…etailed Fix path with contained query
Ladas
added a commit
to Ladas/manageiq
that referenced
this pull request
Dec 16, 2014
Pagination is always forced by Glance conf file. So we need to always obtain all pages of images in cycle. Depends-On: fog/fog#3321 Depends-On: fog/fog#3322 https://bugzilla.redhat.com/show_bug.cgi?id=1164764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query inside path is not allowed, it should be under
separate key :query.
Putting query inside path leads to error:
URI::InvalidComponentError Exception: bad
component(expected absolute path component):
/v1.1/images/detail?limit=20
Caused most probably by this comparison:
URI::parser.regexp[:ABS_PATH] !~ v