OpenStack storage: remap standard Fog attributes (max_keys => limit) #3722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add remapping of standard Fog attributes, like max_keys, to directories. This way users are not forced to add custom 'limit' attributes into the higher level calls they make. This is important, as you might want to write code that's compatible with multiple cloud providers. Explicitly including 'limit' attribute breaks some APIs (e.g. Google Cloud Storage). Now you can use standard fog max_keys to achieve limit functionality on OpenStack SWIFT.
|
Closing till fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add remapping of standard Fog attributes, like max_keys, to directories.
This way users are not forced to add custom 'limit' attributes into the
higher level calls they make. This is important, as you might want to
write code that's compatible with multiple cloud providers. Explicitly
including 'limit' attribute breaks some APIs (e.g. Google Cloud Storage).
With this PR you can use standard fog max_keys to achieve limit functionality on
OpenStack SWIFT.
Note: this has not been fully tested and likely needs a bit more work.