Add #deploy to VcloudDirector::Vm #3937
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To force customization on deployment the vCloud Director API provides an
forceCustomization
attribute in thedeploy
operation. The methodpost_deploy_vapp
which can handle this operation (and accepts this attribute) has been present for many years (lib/fog/vcloud_director/requests/compute/post_deploy_vapp.rb). However currently the method cannot be accessed from aVcloudDirector::Vm
or aVcloudDirector::Vapp
. Hence this proposal to add this method in those classes.During development it raised the following
TaskError
:Should I provide some documentation and testing on the
deploy
method? Are there any other optimizations I can or should add?