Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #deploy to VcloudDirector::Vm #3937

Closed
wants to merge 2 commits into from
Closed

Add #deploy to VcloudDirector::Vm #3937

wants to merge 2 commits into from

Conversation

harmjanblok
Copy link

To force customization on deployment the vCloud Director API provides an forceCustomization attribute in the deploy operation. The method post_deploy_vapp which can handle this operation (and accepts this attribute) has been present for many years (lib/fog/vcloud_director/requests/compute/post_deploy_vapp.rb). However currently the method cannot be accessed from a VcloudDirector::Vm or a VcloudDirector::Vapp. Hence this proposal to add this method in those classes.

During development it raised the following TaskError:

Fog::Compute::VcloudDirector::TaskError: status: error, error: {:majorErrorCode=>"400", :message=>"[ a36d1a98-288a-46ce-9e64-3143c55a2c49 ] Parameter forceCustomization is not supported for vApps.", :minorErrorCode=>"BAD_REQUEST"}

Should I provide some documentation and testing on the deploy method? Are there any other optimizations I can or should add?

@geemus
Copy link
Member

geemus commented Jan 4, 2017

Looks like a good start. I think some documentation and tests would round it out nicely. Thanks!

@stale
Copy link

stale bot commented Jul 30, 2018

This issue has been automatically marked stale due to inactivity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 30, 2018
@stale stale bot closed this Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants