This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
Fogl-68 #12
Merged
Fogl-68 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveen-garg
requested review from
Terris-Dianomic
and removed request for
praveen-garg
Terris-Dianomic
approved these changes
May 24, 2017
praveen-garg
suggested changes
May 24, 2017
src/python/.gitignore
Outdated
| .tox | ||
|
|
||
| # docs/build | ||
| docs/__pycache__/ |
There was a problem hiding this comment.
docs/__pycache__/ should be in root .gitignore; just after docs/build
| elif [ "$option" == "TEST" ] | ||
| then | ||
| echo "tox is on the job; see tox.ini" | ||
| tox |
There was a problem hiding this comment.
add a comment
to run only /src/python/tests, use tox -e py35
tox
# to run only /src/python/tests, use tox -e py35
src/python/tox.ini
Outdated
| pytest | ||
| bash -c "pip uninstall FogLAMP <<< y" | ||
|
|
||
| # TODO fix it |
There was a problem hiding this comment.
use # FIXME: (for TODO, we should use # TODO:) mention issue# if any!
this will help to capture
mshariq-nerd
pushed a commit
to mshariq-nerd/FogLAMP
that referenced
this pull request
Aug 31, 2017
Scheduler integration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FOGL-68
items:
Attached is the pylint-report.txt