Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module path should be "github.com/fogleman/nes", not "nes" #43

Closed
KateGo520 opened this issue Jul 26, 2020 · 3 comments
Closed

Module path should be "github.com/fogleman/nes", not "nes" #43

KateGo520 opened this issue Jul 26, 2020 · 3 comments

Comments

@KateGo520
Copy link

KateGo520 commented Jul 26, 2020

Background

Module path is inconsistent with go import path.
GO111MODULE=on, run go get github.com/fogleman/nes:

$ go get: github.com/fogleman/nes@v0.0.0-20200423142911-c94772f15816: parsing go.mod:
        module declares its path as: nes
                but was required as: github.com/fogleman/nes

Solution

Fix the module path:

Rename the module path to "github.com/fogleman/nes".
https://github.com/fogleman/nes/blob/master/go.mod#L1

module github.com/fogleman/nes
go 1.14
require (
	…
) 
@KateGo520 KateGo520 changed the title Module path should be ”github.com/fogleman/nes”, not “nes” Module path should be "github.com/fogleman/nes", not "nes" Jul 26, 2020
@KateGo520
Copy link
Author

@caixiangyue @fogleman Could you help me review this issue? Thx :p

@d1y
Copy link
Contributor

d1y commented Aug 20, 2020

I also met

go: github.com/fogleman/nes upgrade => v0.0.0-20200423142911-c94772f15816
go get: github.com/fogleman/nes@v0.0.0-20200423142911-c94772f15816: parsing go.mod:
	module declares its path as: nes
	        but was required as: github.com/fogleman/nes

fogleman added a commit that referenced this issue Aug 20, 2020
@fogleman
Copy link
Owner

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants