Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce SBT, bump to Scala 2.10.3 #5

Merged
merged 2 commits into from
May 23, 2014
Merged

Introduce SBT, bump to Scala 2.10.3 #5

merged 2 commits into from
May 23, 2014

Conversation

aerben
Copy link
Contributor

@aerben aerben commented May 11, 2014

A big one, sorry for not splitting it up.

The restructing:

  • introduces the SBT along with the recommended repo layout
  • bumps the code to Scala 2.10.3 along with some minor refactorings of overly verbose type specifications
  • transforms the samples given to ScalaTests
  • extracts Lunar as sample main object
  • removes the obsolete test-all.sh now covered by ScalaTest

Issues:

  • Some tests are ignored as the sampes require input. Console.in will have to be redirected to make this testable.
  • Lunar is not a test for that reason.

Feedback welcome! There is more to come soon, especially regarding the unit tests.

aerben and others added 2 commits May 11, 2014 18:12
…cala 2.10 - fix compile errors, sugar syntax where the compiler lets me. Create ScalaTests from the examples found in the code. Extract Lunar as example application - run this and the tests to check the refactoring.
Not necessary any more.
@aerben aerben mentioned this pull request May 11, 2014
@fogus fogus merged commit 8bcc89b into fogus:master May 23, 2014
@fogus
Copy link
Owner

fogus commented May 23, 2014

Thank you

@aerben aerben deleted the introduceSbt_bumpScala210 branch May 27, 2014 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants