changed handling of target so that any value other than _self will ma…

…ke it external

.travis.yml

@@ -5,4 +5,3 @@ node_js:
   - "0.12"
   - "0.11"
   - "0.10"
-  - "iojs"

README.md

@@ -9,7 +9,7 @@ A simple function that tells you whether a link DOM node is 'external'.
 
 A link is external if it:
 * has the attribute rel="external"
-* has the attribute target="\_blank"
+* has the attribute target and the value is not \_self
 * is an absolute link
 * is a telephone link
 * is a mailto link
@@ -22,3 +22,6 @@ var link = document.querySelector('a');
 
 external(link);
 ```
+
+## Versions
+2.0.0 - changed handling of target so that any value other than \_self will make it external

index.js

@@ -3,7 +3,7 @@
 function external(node) {
   if (!node || !node.getAttribute) return false;
 
-  if (node.getAttribute('target') === '_blank') return true;
+  if (node.getAttribute('target') && node.getAttribute('target') !== '_self') return true;
 
   if (node.getAttribute('rel') === 'external') return true;
 

test.js

@@ -9,7 +9,7 @@ var assert = require('assert');
 
 function makeLinkNode(options, cb) {
   options = extend(false, {
-    url: 'http://aboutandrew.co.uk',
+    url: '/',
     pageUrl: 'http://github.com',
     rel: '',
     target: ''
@@ -147,15 +147,32 @@ describe('External link', function() {
     });
   });
 
-  it('should know a link with target="_blank" is external', function(done) {
-    makeLinkNode({url: 'http://github.com', target: '_blank'}, function(err, link) {
-      assert(external(link));
-      done();
+  context('when a link has a target attribute', function() {
+    it('should know it is external', function(done) {
+      makeLinkNode({target: 'new'}, function(err, link) {
+        assert(external(link));
+        done();
+      });
+    });
+
+    it('should know it is not external if it equals _blank', function(done) {
+      makeLinkNode({target: '_blank'}, function(err, link) {
+        assert(external(link));
+        done();
+      });
+    });
+
+    it('should know it is not external if it equals _self', function(done) {
+      makeLinkNode({target: '_self'}, function(err, link) {
+        assert.equal(external(link), false);
+        done();
+      });
     });
   });
 
+
   it('should know a link with rel="external" is external', function(done) {
-    makeLinkNode({url: 'http://github.com', rel: 'external'}, function(err, link) {
+    makeLinkNode({rel: 'external'}, function(err, link) {
       assert(external(link));
       done();
     });