Support glob patterns in the configuration file #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have more than one entry in the configuration file that match the location string that we are currently using (e.g. one with a trailing slash and another without), we will end up choosing one configuration at random. When this situation arise, we should instead abort the execution to avoid unexpected results. Signed-off-by: Ludovico de Nittis <ludovico.denittis@collabora.com>
This makes the configuration file more flexible. Closes: folbricht#208 Signed-off-by: Ludovico de Nittis <ludovico.denittis@collabora.com>
folbricht
approved these changes
Jan 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bail out if multiple config entries match a single location
If we have more than one entry in the configuration file that match the
location string that we are currently using (e.g. one with a trailing
slash and another without), we will end up choosing one configuration at
random.
When this situation arise, we should instead abort the execution to
avoid unexpected results.
Support glob patterns in the configuration file
This makes the configuration file more flexible.
The first commit has the potential to break backwards compatibility. Right now a configuration file that had both
/foo/barand/foo/bar/was acceptable, and at runtime Desync was choosing one of them in an undefined order.