Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MODFISTO-460] Removed transaction summary schemas #459

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Conversation

damien-git
Copy link
Contributor

Purpose

MODFISTO-460 - Remove the old transaction API (storage)

Approach

Removed the transaction summary schemas.

Merge after the mod-finance-storage PR

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Examples exist for all schemas
    • Descriptions exist for all schema properties
    • All schemas pass raml-cop linting
  • Does this introduce breaking changes?
    • Were there any schema changes?
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@damien-git damien-git marked this pull request as ready for review April 16, 2024 17:35
@damien-git damien-git requested a review from a team April 16, 2024 17:42
@damien-git damien-git merged commit 5c9b08c into master Apr 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants