MODDATAIMP-14 Initial setup for mod-data-import module #1
Conversation
dmytrotur
requested review from
jeremythuff,
kurtnordstrom,
dcrossleyau,
funkymalc,
natali-zaitseva,
ViktorSoroka07,
OleksiiKuzminov,
Igor-Gorchakov,
oleksii-popov,
TarasSpashchenko and
KaterynaSenchenko
| Map<String, String> okapiHeaders, | ||
| Handler<AsyncResult<Response>> asyncResultHandler, | ||
| Context vertxContext) { | ||
| //TODO replace stub response |
There was a problem hiding this comment.
| Map<String, String> okapiHeaders, | ||
| Handler<AsyncResult<Response>> asyncResultHandler, | ||
| Context vertxContext) { | ||
| //TODO replace stub response |
There was a problem hiding this comment.
|
SonarQube analysis reported 3 issues
Watch the comments in this conversation to review them. |
|
|
||
| @Override | ||
| public void init(Vertx vertx, Context context, Handler<AsyncResult<Boolean>> handler) { | ||
| //TODO replace stub init |
There was a problem hiding this comment.
There was a problem hiding this comment.
I did review for ensuring initial setup (not for any other technical review).
The GitHub repository front page still needs the "Description" at the top, but i suppose that you will do that later when the Introduction is added to the README.
Also the README needs a link to your Issue tracker project.
Otherwise, looks good to me.
|
@dcrossleyau, thanks for review. I added link to issue tracker project. |
MODDATAIMP-14
Initial module setup.
Added stubs for API calls.