Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MODFISTO-460] Batch API to load transactions in tenant data #409

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

damien-git
Copy link
Contributor

@damien-git damien-git commented Apr 22, 2024

Purpose

MODFISTO-460 - Remove the old transaction API (storage)

Approach

The previous PR broke the build. This PR changes data loading for the tenant to use the batch API for allocations and transfers.

Reported error:
fatal: [10.36.1.78]: FAILED! => {"changed": false, "connection": "close", "content": "Tenant operation failed for module mod-finance-storage-8.7.0-SNAPSHOT.347: GET http://10.36.1.78:9141/finance-storage/transactions/7468d9f1-26d1-498c-8129-b57c3a19732b returned status 404: Not found POST http://10.36.1.78:9141/finance-storage/transactions returned status 405: null", "content_length": "281", "content_type": "text/plain", "elapsed": 21, "msg": "Status code was 500 and not [200]: HTTP Error 500: Internal Server Error", "redirected": false, "status": 500, "url": "http://10.36.1.78:9130/_/proxy/tenants/diku/install?deploy=true&tenantParameters=loadSample%3Dtrue%2CloadReference%3Dtrue%2CrunReindex%3Dtrue"}

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • Were any API paths or methods changed, added or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all the appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?
  • Did you modify code to call some additional endpoints?
    • If so, do you check that necessary module permission added in ModuleDescriptor-template.yaml file?

Ideally, all the PRs involved in breaking changes would be merged on the same day
to avoid breaking the folio-testing environment.
Communication is paramount if that is to be achieved,
especially as the number of inter-module and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems,
ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@damien-git damien-git self-assigned this Apr 22, 2024
@damien-git damien-git changed the title [MODFISTO-460] Temporarily removed test data creation for allocations and transfers [MODFISTO-460] Batch API to load transactions in tenant data Apr 22, 2024
@damien-git damien-git requested a review from a team April 22, 2024 22:43
Copy link

sonarcloud bot commented Apr 22, 2024

@SerhiiNosko SerhiiNosko merged commit 72c1f22 into master Apr 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants