[MODFISTO-460] Batch API to load transactions in tenant data #409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
MODFISTO-460 - Remove the old transaction API (storage)
Approach
The previous PR broke the build. This PR changes data loading for the tenant to use the batch API for allocations and transfers.
Reported error:
fatal: [10.36.1.78]: FAILED! => {"changed": false, "connection": "close", "content": "Tenant operation failed for module mod-finance-storage-8.7.0-SNAPSHOT.347: GET http://10.36.1.78:9141/finance-storage/transactions/7468d9f1-26d1-498c-8129-b57c3a19732b returned status 404: Not found POST http://10.36.1.78:9141/finance-storage/transactions returned status 405: null", "content_length": "281", "content_type": "text/plain", "elapsed": 21, "msg": "Status code was 500 and not [200]: HTTP Error 500: Internal Server Error", "redirected": false, "status": 500, "url": "http://10.36.1.78:9130/_/proxy/tenants/diku/install?deploy=true&tenantParameters=loadSample%3Dtrue%2CloadReference%3Dtrue%2CrunReindex%3Dtrue"}
Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally, all the PRs involved in breaking changes would be merged on the same day
to avoid breaking the folio-testing environment.
Communication is paramount if that is to be achieved,
especially as the number of inter-module and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems,
ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.