Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MODFQMMGR-333] Expose endpoint to fetch entity types with missing permissions #288

Merged
merged 7 commits into from
Jun 17, 2024
Merged

[MODFQMMGR-333] Expose endpoint to fetch entity types with missing permissions #288

merged 7 commits into from
Jun 17, 2024

Conversation

ncovercash
Copy link
Member

@ncovercash ncovercash commented Jun 17, 2024 •
edited
Loading

ncovercash
ncovercash commented Jun 17, 2024
View reviewed changes
src/main/java/org/folio/fqm/repository/EntityTypeRepository.java
@@ -69,7 +69,7 @@ public Optional<EntityType> getEntityTypeDefinition(UUID entityTypeId) {
});
}

public List<RawEntityTypeSummary> getEntityTypeSummary(Set<UUID> entityTypeIds) {
public List<RawEntityTypeSummary> getEntityTypeSummaries(Set<UUID> entityTypeIds) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been bugging me since the first time i saw the method :p

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ncovercash ncovercash merged commit c6f8b77 into master Jun 17, 2024
6 checks passed
@ncovercash ncovercash deleted the modfqmmgr-333 branch June 17, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvsharp bvsharp bvsharp approved these changes

@kjain110 kjain110 kjain110 approved these changes

@mweaver-ebsco mweaver-ebsco mweaver-ebsco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ncovercash @bvsharp @kjain110 @mweaver-ebsco