Modify visibility data's reason as required by UI and associated tests

folio-org · Jan 17, 2018 · 4c11878 · 4c11878
1 parent 49bdfc2
commit 4c11878
Show file tree

Hide file tree

Showing 6 changed files with 418 additions and 1 deletion.
diff --git a/.gitignore b/.gitignore
@@ -2,4 +2,6 @@ log
 tmp
 .env
 telepresence.log
+.byebug_history
+.vscode/launch.json
 coverage
diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md
@@ -0,0 +1,14 @@
+## Purpose
+_Describe the purpose of the pull request. Include background information if necessary._
+
+## Approach
+_How does this change fulfill the purpose?_
+
+#### TODOS and Open Questions
+- [ ] Use GitHub checklists. When solved, check the box and explain the answer.
+
+## Learning
+_Describe the research stage. Add links to blog posts, patterns, libraries or addons used to solve this problem._
+
+## Screenshots
+_Let's see those sweet visuals!_
diff --git a/app/serializable/serializable_customer_resource.rb b/app/serializable/serializable_customer_resource.rb
@@ -118,7 +118,12 @@ class SerializableCustomerResource < SerializableResource
     @object.resource.vendorName
   end
   attribute :visibilityData do
-    @object.resource.visibilityData
+    visibility = @object.resource.visibilityData
+    if visibility['isHidden']
+      visibility['reason'] =
+        visibility['reason'] == 'Hidden by EP' ? 'Set by System' : ''
+    end
+    visibility
   end
   attribute :managedCoverages do
     @object.resource.managedCoverageList

diff --git a/spec/fixtures/vcr_cassettes/get-customer-resource-reason-hidden-by-customer.yml b/spec/fixtures/vcr_cassettes/get-customer-resource-reason-hidden-by-customer.yml
diff --git a/spec/fixtures/vcr_cassettes/get-customer-resource-reason-hidden-by-ep.yml b/spec/fixtures/vcr_cassettes/get-customer-resource-reason-hidden-by-ep.yml