Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODOAIPMH-433: embedded-postgresql-maven-plugin -> docker-maven-plugin #308

Closed
wants to merge 27 commits into from

Conversation

julianladisch
Copy link
Contributor

Purpose

Can build on ARM.

Approach

Switch from embedded-postgresql-maven-plugin to docker-maven-plugin.

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • Check logging
    • There are no major code smells or security issues

This PR hard-codes the gateway IP address of Docker used during the build. If a developer or a build environment uses a non-default gateway IP address the build will fail. This doesn't affect the runtime, though.

khandramai and others added 26 commits March 17, 2023 16:54
@julianladisch
Copy link
Contributor Author

@steveellis Please check whether this successfully builds on ARM.

@steveellis
Copy link

@julianladisch sorry it doesn't seem to be working on our ARM Jenkins. Same on ARM mac. Attaching logs.

oai-pmh-jenkins.log

@julianladisch
Copy link
Contributor Author

Hi @steveellis , I cannot reproduce your issue, my .circleci/config.yml successfully builds on aarch64.

The error

Unable to execute or load jffi binary stub from

might get fixed by

@sonarcloud
Copy link

sonarcloud bot commented Apr 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julianladisch
Copy link
Contributor Author

Included into #322.

@julianladisch julianladisch deleted the MODOAIPMH-433-docker-approach-julian branch May 23, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants