feat(consortium-search): Implement consolidated items/holdings search #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # descriptors/ModuleDescriptor-template.json # src/main/java/org/folio/search/controller/SearchConsortiumController.java # src/main/resources/swagger.api/mod-search.yaml
…lding from instance
- Implement endpoints by id - Implement batch endpoints by ids Implements: MSEARCH-759
viacheslavkol
requested review from
psmagin,
mukhiddin-yusuf and
viacheslavpoliakov
psmagin
requested changes
May 28, 2024
- Fix permission names in module descriptor
src/main/java/org/folio/search/controller/SearchConsortiumController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/search/converter/ConsortiumHoldingMapper.java
Outdated
Show resolved
Hide resolved
psmagin
approved these changes
May 30, 2024
mukhiddin-yusuf
approved these changes
May 30, 2024
viacheslavpoliakov
approved these changes
May 30, 2024
Comment on lines
+147
to
+153
| private String verifyAndGetTenant(String tenantHeader) { | ||
| var centralTenant = consortiumTenantService.getCentralTenant(tenantHeader); | ||
| if (centralTenant.isEmpty() || !centralTenant.get().equals(tenantHeader)) { | ||
| throw new RequestValidationException(REQUEST_NOT_ALLOWED_MSG, XOkapiHeaders.TENANT, tenantHeader); | ||
| } | ||
| return centralTenant.get(); | ||
| } |
There was a problem hiding this comment.
I don't like methods like doSomeAndDoSomeAnd...
May be better way to do something like next
private String getVerifiedTenant(String tenantHeader) {
verifyTenant(tenantHeader)
return consortiumTenantService.getCentralTenant(tenantHeader).get();
}
private void verifyTenant(String tenantHeader) {
var centralTenant = consortiumTenantService.getCentralTenant(tenantHeader);
if (centralTenant.isEmpty() || !centralTenant.get().equals(tenantHeader)) {
throw new RequestValidationException(REQUEST_NOT_ALLOWED_MSG, XOkapiHeaders.TENANT, tenantHeader);
}
}
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Implement consolidated items/holdings search
Approach
Changes Checklist
Related Issues
MSEARCH-759