-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MSEARCH-784] add bibframe authority index #605
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkjacob
reviewed
Jun 18, 2024
.../java/org/folio/search/service/setter/bibframe/authority/BibframeAuthorityLccnProcessor.java
Outdated
Show resolved
Hide resolved
pkjacob
reviewed
Jun 18, 2024
src/main/java/org/folio/search/integration/KafkaMessageListener.java
Outdated
Show resolved
Hide resolved
Hi @aleksei-pronichev, Let us add following new line in News.md file (line 22)
|
pkjacob
reviewed
Jun 18, 2024
pkjacob
reviewed
Jun 18, 2024
pkjacob
reviewed
Jun 18, 2024
0f135ad
to
4212378
Compare
PBobylev
approved these changes
Jun 19, 2024
src/main/resources/swagger.api/schemas/dto/bibframe/bibframeAuthority.yaml
Outdated
Show resolved
Hide resolved
4212378
to
8ba03f0
Compare
psmagin
reviewed
Jun 19, 2024
psmagin
reviewed
Jun 19, 2024
src/main/java/org/folio/search/controller/SearchController.java
Outdated
Show resolved
Hide resolved
psmagin
reviewed
Jun 19, 2024
cf5d149
to
2f554b3
Compare
pkjacob
approved these changes
Jun 21, 2024
Hi @aleksei-pronichev, There are some merge conflicts with master branch. Let us address it. |
pkjacob
reviewed
Jun 21, 2024
.../java/org/folio/search/service/setter/bibframe/authority/BibframeAuthorityTypeProcessor.java
Outdated
Show resolved
Hide resolved
PBobylev
approved these changes
Jun 21, 2024
2f554b3
to
bf508d5
Compare
pkjacob
approved these changes
Jun 24, 2024
psmagin
requested changes
Jun 25, 2024
e2fa0a6
to
80b80d1
Compare
80b80d1
to
afc0e7c
Compare
psmagin
approved these changes
Jun 26, 2024
afc0e7c
to
902a3a4
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
add bibframe authority index for mod-linked-data module
Approach
add a new kafka topic with new data for bibframe authority index
Changes Checklist
Related Issues
[MSEARCH-784] (https://folio-org.atlassian.net/browse/MSEARCH-784)