Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMB-587: Prepare f_unaccent indexes #654

Merged
merged 2 commits into from May 12, 2020

Conversation

julianladisch
Copy link
Contributor

@julianladisch julianladisch commented May 11, 2020

RMB-587

Prepare new f_unaccent indexes in addition
to the existing indexes. This takes some time, but this time is saved when upgrading the module to RMB >= 29.4 (Goldenrod). Upgrade to RMB 29.3.3 to create these indexes in advance, for example at night a few days before the module upgrade to Goldenrod.
The new indexes have the _p name suffix and are updated on CRUD operations of the underlying data.
When upgrading to RMB >= 29.4 the old index is deleted and replaced by the new index, this is a fast index rename without index recreation.

@sonarcloud
Copy link

sonarcloud bot commented May 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 83 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@adamdickmeiss adamdickmeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I assume you have tested this with a real module..

@julianladisch
Copy link
Contributor Author

I've successfully tested it with mod-inventory-storage. On a million instances it reduces the upgrade time by more than 50%.

@julianladisch julianladisch merged commit ef0efd6 into b29.3 May 12, 2020
@julianladisch julianladisch deleted the RMB-587-prepare-f_unaccent-indexes branch May 12, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants