Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOM-829 next/prev pagination and MCL sparse array support. #1554

Merged
merged 19 commits into from
May 27, 2021

Conversation

JohnC-80
Copy link
Contributor

@JohnC-80 JohnC-80 commented May 5, 2021

Creates an alternative to 'load more' button with forward/back navigation and a view at the current 'slice's items.
image

This also adds support for sparse arrays.

@folio-org folio-org deleted a comment from id-jenkins May 5, 2021
@folio-org folio-org deleted a comment from id-jenkins May 5, 2021
@folio-org folio-org deleted a comment from id-jenkins May 21, 2021
@folio-org folio-org deleted a comment from id-jenkins May 21, 2021
@folio-org folio-org deleted a comment from id-jenkins May 21, 2021
@folio-org folio-org deleted a comment from id-jenkins May 21, 2021
@JohnC-80 JohnC-80 marked this pull request as ready for review May 21, 2021 18:54
@folio-org folio-org deleted a comment from id-jenkins May 21, 2021
@JohnC-80 JohnC-80 requested a review from doytch May 24, 2021 21:03
@sonarcloud
Copy link

sonarcloud bot commented May 24, 2021

@JohnC-80 JohnC-80 merged commit dcd8e00 into master May 27, 2021
JohnC-80 added a commit that referenced this pull request May 27, 2021
* add 'scroll-to-item' logic

* add item-to-view story

* clean lint

* add tests for ItemToView

* WIP: Stcom 829 next/prev pagination and MCL sparse array support. (#1554)

* stories examples

* break out pagination rows to their own components

* add sparse array support to MCL

* aesthetics adjustments

* add 1 to indices

* clean up lint, move inline styles to CSS classes

* stablize legacy behavior after changes

* add scroll values to MCL's onScroll prop

* adjust styles for disabled pagination buttons, disable next will be based on totalCount prop, if present

* export paging types as constants, adjust styles for pagination row

* fix prev-next rendering on last page of results

* resolve lint

* fix test regressions

* test prev-next pagination, sparse array suport

* remove comments

* update documentation for pagingType prop

* add note about sparse array support

* resolve conflicts

* add item-to-view story

* resolve lint conflict

* resolve conflict

* fix merge issue with MCL tests

* resolve conflict in MCL tests

* update changelog
@zburke zburke deleted the STCOM-829-prev-next-pagination branch May 28, 2021 13:18
@zburke zburke changed the title WIP: Stcom 829 next/prev pagination and MCL sparse array support. STCOM-829 next/prev pagination and MCL sparse array support. May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants