-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STCOM-829 next/prev pagination and MCL sparse array support. #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ased on totalCount prop, if present
SonarCloud Quality Gate failed. |
mkuklis
approved these changes
May 25, 2021
JohnC-80
added a commit
that referenced
this pull request
May 27, 2021
* add 'scroll-to-item' logic * add item-to-view story * clean lint * add tests for ItemToView * WIP: Stcom 829 next/prev pagination and MCL sparse array support. (#1554) * stories examples * break out pagination rows to their own components * add sparse array support to MCL * aesthetics adjustments * add 1 to indices * clean up lint, move inline styles to CSS classes * stablize legacy behavior after changes * add scroll values to MCL's onScroll prop * adjust styles for disabled pagination buttons, disable next will be based on totalCount prop, if present * export paging types as constants, adjust styles for pagination row * fix prev-next rendering on last page of results * resolve lint * fix test regressions * test prev-next pagination, sparse array suport * remove comments * update documentation for pagingType prop * add note about sparse array support * resolve conflicts * add item-to-view story * resolve lint conflict * resolve conflict * fix merge issue with MCL tests * resolve conflict in MCL tests * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates an alternative to 'load more' button with forward/back navigation and a view at the current 'slice's items.
![image](https://user-images.githubusercontent.com/20704067/119176072-41332700-ba30-11eb-969f-b4124c5e09ad.png)
This also adds support for sparse arrays.