Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOM-1058: After click submit button disable the confirmation button in ConfirmationModal component #1912

Merged
merged 5 commits into from
Nov 29, 2022

Conversation

OleksandrHladchenko1
Copy link
Contributor

Link

STCOM-1058

UIDATIMP-1299.mp4

@github-actions
Copy link

github-actions bot commented Nov 22, 2022

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit e3ff9bf. ± Comparison against base commit b01d41c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 22, 2022

BigTest Unit Test Statistics

       1 files  ±0         1 suites  ±0   12s ⏱️ +2s
1 304 tests +1  1 298 ✔️ +1  6 💤 ±0  0 ±0 
1 307 runs  +1  1 301 ✔️ +1  6 💤 ±0  0 ±0 

Results for commit e3ff9bf. ± Comparison against base commit b01d41c.

♻️ This comment has been updated with latest results.

Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad to see this useful behavior. Please add a test that confirms it works as expected.

@OleksandrHladchenko1
Copy link
Contributor Author

Done!
cc: @zburke @JohnC-80

Copy link
Contributor

@JohnC-80 JohnC-80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for adding the test! Please add a documentation bit to https://github.com/folio-org/stripes-components/tree/master/lib/ConfirmationModal#readme with the new prop.

@sonarcloud
Copy link

sonarcloud bot commented Nov 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@OleksandrHladchenko1 OleksandrHladchenko1 merged commit 58cd763 into master Nov 29, 2022
@OleksandrHladchenko1 OleksandrHladchenko1 deleted the STCOM-1058 branch November 29, 2022 14:04
github-actions bot pushed a commit that referenced this pull request Nov 29, 2022
… in ConfirmationModal component (#1912)

* STCOM-1058: After click submit button disable the confirmation button in Confirmation modal component

* STCOM-1058: Add test

* STCOM-1058: Fix test

* STCOM-1058: Add new render in beforeEach

* STCOM-1058: Update the documentation
OleksandrHladchenko1 added a commit that referenced this pull request Dec 4, 2022
… in ConfirmationModal component (#1912)

* STCOM-1058: After click submit button disable the confirmation button in Confirmation modal component

* STCOM-1058: Add test

* STCOM-1058: Fix test

* STCOM-1058: Add new render in beforeEach

* STCOM-1058: Update the documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants