STCOM-1282. Multiselection overlay overlapping input under certain conditions. #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-blazhko
approved these changes
Apr 19, 2024
zburke
approved these changes
Apr 19, 2024
BogdanDenis
approved these changes
Apr 22, 2024
|
github-actions bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
…nditions. (#2269) * if renderToOverlay is used, set the boundary to the overlay container * log changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The positioning of
<MultiSelection/>'s overlay element is completely controlled by thepopperlibrary. To affect the placement at the instance level,popper's options include an object with 'modifiers' - a bunch of different adjustments that are applied/accounted for when the overlay element is rendered. One of them is 'preventOverflow' that keeps an element within the bounds of a certain scrollable parent/element. It defaults to thescrollParentof the input the overlay belongs to.The case sited in STCOM-1282 has
<MultiSelection>being used within a *short<EditableList>. ThescrollParent- theMCL's scrollable element - with only 3 items is not tall enough to render the overlay without it overlapping the<MultiSelection>control. TherenderToOverlayprop is used as it should be on theMultiSelection, butpopperstill wants to stick to MCL's scrollable element as its boundary.Approach
This PR changes the setting applied to
popperiin<MultiSelection>if therenderToOverlayprop is used, setting theboundaryElementof thepreventOverflowmodifier to thediv#OverlayContainerrendered within the stripes UI.