Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOM-1291 avoid defaultProps in functional components #2285

Merged
merged 4 commits into from
May 15, 2024
Merged

Conversation

zburke
Copy link
Member

@zburke zburke commented May 13, 2024

defaultProps for functional components will be deprecated in React v19 in favor of ES6 default parameters.

Refs STCOM-1291

`defaultProps` for functional components will be deprecated in React v19
in favor of ES6 default parameters.

Refs STCOM-1291
@zburke zburke requested a review from JohnC-80 May 13, 2024 13:39
@zburke
Copy link
Member Author

zburke commented May 13, 2024

@JohnC-80 , there are a few test failures here that I can't suss. Can you take a look?

Copy link

github-actions bot commented May 13, 2024

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit fb3aa29. ± Comparison against base commit 0f6e440.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 13, 2024

BigTest Unit Test Statistics

       1 files  ±0         1 suites  ±0   13s ⏱️ ±0s
1 450 tests ±0  1 444 ✔️ ±0  6 💤 ±0  0 ±0 
1 452 runs  ±0  1 446 ✔️ ±0  6 💤 ±0  0 ±0 

Results for commit fb3aa29. ± Comparison against base commit 0f6e440.

♻️ This comment has been updated with latest results.

lib/Button/Button.js Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented May 14, 2024

@zburke zburke marked this pull request as ready for review May 14, 2024 16:58
@zburke zburke merged commit a04def6 into master May 15, 2024
6 checks passed
@zburke zburke deleted the STCOM-1291 branch May 15, 2024 17:00
github-actions bot pushed a commit that referenced this pull request May 15, 2024
`defaultProps` for functional components will be deprecated in React v19
in favor of ES6 default parameters.

Refs STCOM-1291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants