STCOR-845 Redirect correctly after changing password #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zburke
approved these changes
May 7, 2024
There was a problem hiding this comment.
The code looks correct to me but :
- The shape of
stripesin the code and in the prop-types must align (just make stripes an object; proptypes go byebye in React v19). - Please describe the solution (which new code implements) not the problem (which old code, now removed) caused. If you're ever starting a commit title with "Fix...", this is a clue that you've got the wrong end of the stick. Maybe sth like "Redirect correctly after changing password"?
aidynoJ
approved these changes
May 7, 2024
ryandberger
changed the title
ryandberger
added a commit
that referenced
this pull request
May 15, 2024
* Navigate to base URL if using Eureka since backend doesn't recognize /login
zburke
pushed a commit
that referenced
this pull request
Jun 11, 2024
* Navigate to base URL if using Eureka since backend doesn't recognize /login
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/loginroute, so base URL/should be used instead.