Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test validator functions #1471

Merged
merged 4 commits into from
May 29, 2024
Merged

test validator functions #1471

merged 4 commits into from
May 29, 2024

Conversation

zburke
Copy link
Member

@zburke zburke commented May 14, 2024

Provide tests for validateEmail, validatePhoneNumber, validateForgotUsernameForm.

Provide tests for `validateEmail`, `validatePhoneNumber`,
`validateForgotUsernameForm`.
@zburke zburke requested a review from JohnC-80 May 14, 2024 23:09
Copy link

github-actions bot commented May 14, 2024

Jest Unit Test Statistics

222 tests  +15   222 ✔️ +15   51s ⏱️ -1s
  34 suites +  3       0 💤 ±  0 
    1 files   ±  0       0 ±  0 

Results for commit 77a519d. ± Comparison against base commit 05badf9.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 14, 2024

BigTest Unit Test Statistics

    1 files  ±0      1 suites  ±0   11s ⏱️ ±0s
270 tests ±0  264 ✔️ ±0  6 💤 ±0  0 ±0 
273 runs  ±0  267 ✔️ ±0  6 💤 ±0  0 ±0 

Results for commit 77a519d. ± Comparison against base commit 05badf9.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.
      equal to check email label in english translation
      equal to check email precautions label in english translation
      equal to sent email precautions label in english translation
Chrome_125_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the header with an appropriate text content
Chrome_125_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
Chrome_125_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the header with an appropriate text content
      equal to check email label in english translation
Chrome_125_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
      equal to check email precautions label in english translation
Chrome_125_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
      equal to sent email precautions label in english translation

♻️ This comment has been updated with latest results.

@zburke zburke changed the title add tests for validators test validator functions May 15, 2024
Copy link

Jest Unit Test Results

222 tests  +15   222 ✅ +15   45s ⏱️ -1s
 34 suites + 3     0 💤 ± 0 
  1 files   ± 0     0 ❌ ± 0 

Results for commit cc9cf40. ± Comparison against base commit 7b08224.

Copy link

Jest Unit Test Results

222 tests  +15   222 ✅ +15   45s ⏱️ -1s
 34 suites + 3     0 💤 ± 0 
  1 files   ± 0     0 ❌ ± 0 

Results for commit cc9cf40. ± Comparison against base commit 7b08224.

Copy link

github-actions bot commented May 29, 2024

Bigtest Unit Test Results

193 tests  ±0   188 ✅ ±0   6s ⏱️ ±0s
  1 suites ±0     5 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit cc9cf40. ± Comparison against base commit 7b08224.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.
      equal to check email label in english translation
      equal to check email precautions label in english translation
      equal to sent email precautions label in english translation
Chrome_125_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
Chrome_125_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
Chrome_125_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
      equal to check email label in english translation
Chrome_125_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to check email precautions label in english translation
Chrome_125_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to sent email precautions label in english translation

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@zburke zburke merged commit 4312058 into master May 29, 2024
26 checks passed
@zburke zburke deleted the test-validators branch May 29, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants