provide various missing unit tests

[zburke]

Provide tests for hideEmail, loginServices, okapiActions, okapiReducer, and processBadResponse.

Tiny refactor of some loginServices functions to:

• consistently test for success, else handle an error
• consistently test for success in responses by checking response.ok rather than response.status. consistency is nice. it's predictable.

[github-actions]

Jest Unit Test Statistics

    1 files  ±  0    33 suites  +2   47s ⏱️ -1s
258 tests +51  258 ✔️ +51  0 💤 ±0  0 ❌ ±0 
259 runs  +52  259 ✔️ +52  0 💤 ±0  0 ❌ ±0 

Results for commit a3a63d3. ± Comparison against base commit 142ff27.

♻️ This comment has been updated with latest results.

[github-actions]

BigTest Unit Test Statistics

    1 files  ±0      1 suites  ±0   10s ⏱️ ±0s
270 tests ±0  264 ✔️ ±0  6 💤 ±0  0 ❌ ±0 
273 runs  ±0  267 ✔️ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit a3a63d3. ± Comparison against base commit 142ff27.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.

      equal to check email label in english translation
      equal to check email precautions label in english translation
      equal to sent email precautions label in english translation
Chrome_125_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the header with an appropriate text content
Chrome_125_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content

Chrome_125_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the header with an appropriate text content
      equal to check email label in english translation
Chrome_125_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
      equal to check email precautions label in english translation
Chrome_125_0_0_0_(Linux_x86_64).Forgot username form test check email status page tests ‑ Forgot username form test check email status page tests should have the paragraph with an appropriate text content
      equal to sent email precautions label in english translation

♻️ This comment has been updated with latest results.

[github-actions]

Jest Unit Test Results

  1 files  ± 0   38 suites  +2   46s ⏱️ ±0s
279 tests +51  279 ✅ +51  0 💤 ±0  0 ❌ ±0 
280 runs  +52  280 ✅ +52  0 💤 ±0  0 ❌ ±0 

Results for commit d23abf6. ± Comparison against base commit 9d7cee9.

[github-actions]

Jest Unit Test Results

  1 files  ± 0   38 suites  +2   47s ⏱️ ±0s
283 tests +51  283 ✅ +51  0 💤 ±0  0 ❌ ±0 
284 runs  +52  284 ✅ +52  0 💤 ±0  0 ❌ ±0 

Results for commit a9594c6. ± Comparison against base commit e93a5af.

♻️ This comment has been updated with latest results.

[github-actions]

Bigtest Unit Test Results

193 tests  ±0   188 ✅ ±0   6s ⏱️ ±0s
  1 suites ±0     5 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit a9594c6. ± Comparison against base commit e93a5af.

This pull request removes 5 and adds 3 tests. Note that renamed tests count towards both.

      equal to check email label in english translation
      equal to check email precautions label in english translation
      equal to sent email precautions label in english translation
Chrome_125_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
Chrome_125_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content

Chrome_125_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the header with an appropriate text content
      equal to check email label in english translation
Chrome_125_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to check email precautions label in english translation
Chrome_125_0_0_0_(Linux_x86_64).Forgot username/password status test check email status page tests ‑ Forgot username/password status test check email status page tests should have the paragraph with an appropriate text content
      equal to sent email precautions label in english translation

♻️ This comment has been updated with latest results.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
44.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud