Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enzyme and react-addons-test-utils #332

Merged
merged 4 commits into from Jul 12, 2018
Merged

Remove enzyme and react-addons-test-utils #332

merged 4 commits into from Jul 12, 2018

Conversation

cherewaty
Copy link
Collaborator

Purpose

yarn install gave warnings about unmet peer dependencies for enzyme and react-addons-test-utils. The enzyme version specified didn't work with React 16, and react-addons-test-utils is deprecated as of React 16.

The only test using enzyme in this repo was routes.js.disabled, which appears to have been disabled since March 2017: f803bc3#diff-9c45fa6561a34e0c866002ae185407f0

Approach

Remove enzyme, react-addons-test-utils, and routes.js.disabled test.

stripes-connect is the only other folio-org repo using enzyme, and it defines its own dependency on it.

@cherewaty cherewaty requested a review from skomorokh June 21, 2018 11:49
@id-jenkins

This comment has been minimized.

@cherewaty
Copy link
Collaborator Author

bump @skomorokh

Copy link
Contributor

@skomorokh skomorokh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, doesn't seem like those defunct tests are going to be resurrected nor will future tests use that approach.

Does anything else use mock-require?

@cherewaty
Copy link
Collaborator Author

Nothing else in folio-org was using mock-require, so I removed that too.

@cherewaty cherewaty merged commit 5212bf8 into folio-org:master Jul 12, 2018
@cherewaty cherewaty deleted the jc/dependency-updates branch July 12, 2018 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants