ERM-999: Add record/row identifiers into Local KB Admin log display #283

peterboehm · 2020-09-18T13:32:49Z

No description provided.

id-jenkins · 2020-09-18T13:35:06Z

yarn run v1.22.4 $ eslint lib tests

/home/jenkins/workspace/rg_stripes-erm-components_PR-283/project/lib/LogsList/LogsList.js
4:27 warning 'NoValue' is defined but never used no-unused-vars
9:1 error Expected indentation of 6 spaces but found 8 indent
10:1 error Expected indentation of 6 spaces but found 8 indent
11:1 error Expected indentation of 8 spaces but found 12 indent
12:1 error Expected indentation of 8 spaces but found 12 indent
13:1 error Expected indentation of 6 spaces but found 8 indent
14:1 error Expected indentation of 6 spaces but found 8 indent
15:1 error Expected indentation of 6 spaces but found 8 indent
19:1 error Expected indentation of 6 spaces but found 8 indent
20:1 error Expected indentation of 8 spaces but found 12 indent
21:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent
22:21 error Expected indentation of 18 space characters but found 20 react/jsx-indent
23:21 error Expected indentation of 18 space characters but found 20 react/jsx-indent
24:21 error Expected indentation of 18 space characters but found 20 react/jsx-indent
25:21 error Expected indentation of 18 space characters but found 20 react/jsx-indent
27:1 error Expected indentation of 8 spaces but found 12 indent
28:1 error Expected indentation of 6 spaces but found 8 indent
32:1 error Expected indentation of 6 spaces but found 8 indent
34:1 error Expected indentation of 6 spaces but found 8 indent
35:1 error Expected indentation of 6 spaces but found 8 indent
37:1 error Expected indentation of 6 spaces but found 8 indent
38:13 error Expected indentation of 10 space characters but found 12 react/jsx-indent
39:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
40:1 error Expected indentation of 18 spaces but found 20 indent
41:1 error Expected indentation of 18 spaces but found 20 indent
43:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
44:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
45:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
46:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
47:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
48:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
49:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
50:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
51:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
52:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
53:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
55:1 error Expected indentation of 6 spaces but found 8 indent

✖ 37 problems (36 errors, 1 warning)
36 errors and 0 warnings potentially fixable with the --fix option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

id-jenkins · 2020-09-18T13:36:43Z

yarn run v1.22.4 $ eslint lib tests

/home/jenkins/workspace/rg_stripes-erm-components_PR-283/project/lib/LogsList/LogsList.js
4:27 warning 'NoValue' is defined but never used no-unused-vars
9:1 error Expected indentation of 6 spaces but found 8 indent
10:1 error Expected indentation of 6 spaces but found 8 indent
11:1 error Expected indentation of 8 spaces but found 12 indent
12:1 error Expected indentation of 8 spaces but found 12 indent
13:1 error Expected indentation of 6 spaces but found 8 indent
14:1 error Expected indentation of 6 spaces but found 8 indent
15:1 error Expected indentation of 6 spaces but found 8 indent
19:1 error Expected indentation of 6 spaces but found 8 indent
20:1 error Expected indentation of 8 spaces but found 12 indent
21:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent
22:21 error Expected indentation of 18 space characters but found 20 react/jsx-indent
23:21 error Expected indentation of 18 space characters but found 20 react/jsx-indent
24:21 error Expected indentation of 18 space characters but found 20 react/jsx-indent
25:21 error Expected indentation of 18 space characters but found 20 react/jsx-indent
27:1 error Expected indentation of 8 spaces but found 12 indent
28:1 error Expected indentation of 6 spaces but found 8 indent
32:1 error Expected indentation of 6 spaces but found 8 indent
34:1 error Expected indentation of 6 spaces but found 8 indent
35:1 error Expected indentation of 6 spaces but found 8 indent
37:1 error Expected indentation of 6 spaces but found 8 indent
38:13 error Expected indentation of 10 space characters but found 12 react/jsx-indent
39:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
40:1 error Expected indentation of 18 spaces but found 20 indent
41:1 error Expected indentation of 18 spaces but found 20 indent
43:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
44:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
45:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
46:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
47:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
48:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
49:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
50:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
51:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
52:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
53:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
55:1 error Expected indentation of 6 spaces but found 8 indent

✖ 37 problems (36 errors, 1 warning)
36 errors and 0 warnings potentially fixable with the --fix option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

adi-mat

Looks good to me. Some minor tweaks and linitng errors need to be fixed.

adi-mat · 2020-09-18T15:47:54Z

lib/LogsList/LogsList.js

-  render() {
-    const { job, logs, onNeedMoreLogs, type } = this.props;
+    resultsFormatter = {
+        recordDescriptor: ({ additionalInfo }) => {


Suggested change

recordDescriptor: ({ additionalInfo }) => {

recordDescriptor: ({ additionalInfo = {} }) => {

const { packageSource, packageSource, rowNumber, recordNumber } = additionalInfo;

adi-mat · 2020-09-18T15:50:29Z

lib/LogsList/LogsList.js

+                <div>
+                    {additionalInfo.packageSource ? <FormattedMessage id="stripes-erm-components.packageSource" tagName="div" values={{ source: additionalInfo.packageSource }} /> : null}
+                    {additionalInfo.packageReference ? <FormattedMessage id="stripes-erm-components.packageReference" tagName="div" values={{ ref: additionalInfo.packageReference }} /> : null}
+                    {additionalInfo.rowNumber ? <FormattedMessage id="stripes-erm-components.rowNumber" tagName="div" values={{ rownumber: additionalInfo.rowNumber }} /> : null}
+                    {additionalInfo.recordNumber ? <FormattedMessage id="stripes-erm-components.recordNumber" tagName="div" values={{ recordnumber: additionalInfo.recordNumber }} /> : null}
+                </div>


With the above requested change the additionalInfo.packageSource could just be replaced with packageSource. Similarly with packageReference, rowNumber and recordNumber. Its more cleaner that way as we dont need to fetch the property from additionalInfo everytime.

translations/stripes-erm-components/en.json

translations/stripes-erm-components/en_US.json

id-jenkins · 2020-09-21T15:34:02Z

yarn run v1.22.4 $ eslint lib tests

/home/jenkins/workspace/rg_stripes-erm-components_PR-283/project/lib/LogsList/LogsList.js
4:27 warning 'NoValue' is defined but never used no-unused-vars
9:1 error Expected indentation of 6 spaces but found 8 indent
10:1 error Expected indentation of 6 spaces but found 8 indent
11:1 error Expected indentation of 8 spaces but found 12 indent
12:1 error Expected indentation of 8 spaces but found 12 indent
13:1 error Expected indentation of 6 spaces but found 8 indent
14:1 error Expected indentation of 6 spaces but found 8 indent
15:1 error Expected indentation of 6 spaces but found 8 indent
19:1 error Expected indentation of 6 spaces but found 8 indent
20:1 error Expected indentation of 8 spaces but found 12 indent
21:1 error Expected indentation of 8 spaces but found 12 indent
22:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent
23:21 error Expected indentation of 18 space characters but found 20 react/jsx-indent
24:21 error Expected indentation of 18 space characters but found 20 react/jsx-indent
25:21 error Expected indentation of 18 space characters but found 20 react/jsx-indent
26:21 error Expected indentation of 18 space characters but found 20 react/jsx-indent
28:1 error Expected indentation of 8 spaces but found 12 indent
29:1 error Expected indentation of 6 spaces but found 8 indent
33:1 error Expected indentation of 6 spaces but found 8 indent
35:1 error Expected indentation of 6 spaces but found 8 indent
36:1 error Expected indentation of 6 spaces but found 8 indent
38:1 error Expected indentation of 6 spaces but found 8 indent
39:13 error Expected indentation of 10 space characters but found 12 react/jsx-indent
40:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
41:1 error Expected indentation of 18 spaces but found 20 indent
42:1 error Expected indentation of 18 spaces but found 20 indent
44:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
45:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
46:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
47:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
48:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
49:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
50:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
51:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
52:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
53:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
54:17 error Expected indentation of 14 space characters but found 16 react/jsx-indent-props
56:1 error Expected indentation of 6 spaces but found 8 indent

✖ 38 problems (37 errors, 1 warning)
37 errors and 0 warnings potentially fixable with the --fix option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

id-jenkins · 2020-09-21T15:41:37Z

yarn run v1.22.4 $ eslint lib tests

/home/jenkins/workspace/rg_stripes-erm-components_PR-283/project/lib/LogsList/LogsList.js
22:15 error Expected indentation of 10 space characters but found 14 react/jsx-indent
23:19 error Expected indentation of 16 space characters but found 18 react/jsx-indent
24:19 error Expected indentation of 16 space characters but found 18 react/jsx-indent
25:19 error Expected indentation of 16 space characters but found 18 react/jsx-indent
26:19 error Expected indentation of 16 space characters but found 18 react/jsx-indent
39:11 error Expected indentation of 8 space characters but found 10 react/jsx-indent
40:15 error Expected indentation of 12 space characters but found 14 react/jsx-indent-props
41:1 error Expected indentation of 16 spaces but found 18 indent
42:1 error Expected indentation of 16 spaces but found 18 indent
44:15 error Expected indentation of 12 space characters but found 14 react/jsx-indent-props
45:15 error Expected indentation of 12 space characters but found 14 react/jsx-indent-props
46:15 error Expected indentation of 12 space characters but found 14 react/jsx-indent-props
47:15 error Expected indentation of 12 space characters but found 14 react/jsx-indent-props
48:15 error Expected indentation of 12 space characters but found 14 react/jsx-indent-props
49:15 error Expected indentation of 12 space characters but found 14 react/jsx-indent-props
50:15 error Expected indentation of 12 space characters but found 14 react/jsx-indent-props
51:15 error Expected indentation of 12 space characters but found 14 react/jsx-indent-props
52:15 error Expected indentation of 12 space characters but found 14 react/jsx-indent-props
53:15 error Expected indentation of 12 space characters but found 14 react/jsx-indent-props
54:15 error Expected indentation of 12 space characters but found 14 react/jsx-indent-props

✖ 20 problems (20 errors, 0 warnings)
20 errors and 0 warnings potentially fixable with the --fix option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

id-jenkins · 2020-09-21T15:46:26Z

yarn run v1.22.4 $ eslint lib tests

/home/jenkins/workspace/rg_stripes-erm-components_PR-283/project/lib/LogsList/LogsList.js
40:13 error Expected indentation of 10 space characters but found 12 react/jsx-indent-props
41:1 error Expected indentation of 14 spaces but found 16 indent
42:1 error Expected indentation of 14 spaces but found 16 indent
44:13 error Expected indentation of 10 space characters but found 12 react/jsx-indent-props
45:13 error Expected indentation of 10 space characters but found 12 react/jsx-indent-props
46:13 error Expected indentation of 10 space characters but found 12 react/jsx-indent-props
47:13 error Expected indentation of 10 space characters but found 12 react/jsx-indent-props
48:13 error Expected indentation of 10 space characters but found 12 react/jsx-indent-props
49:13 error Expected indentation of 10 space characters but found 12 react/jsx-indent-props
50:13 error Expected indentation of 10 space characters but found 12 react/jsx-indent-props
51:13 error Expected indentation of 10 space characters but found 12 react/jsx-indent-props
52:13 error Expected indentation of 10 space characters but found 12 react/jsx-indent-props
53:13 error Expected indentation of 10 space characters but found 12 react/jsx-indent-props
54:13 error Expected indentation of 10 space characters but found 12 react/jsx-indent-props

✖ 14 problems (14 errors, 0 warnings)
14 errors and 0 warnings potentially fixable with the --fix option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

peterboehm · 2020-09-21T15:59:52Z

@aditya-matukumalli Thanks for the suggestions! I updated the code accordingly

sonarcloud · 2020-09-21T20:49:45Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

0.0% Coverage
0.0% Duplication

The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

peterboehm added 7 commits September 16, 2020 15:56

ERM-999

bbbd20b

Merge branch 'master' into ERM-999

585d1db

ERM-999

51780a1

ERM-999

41024d2

ERM-999

a8c0ce9

ERM-999

d71a5d6

Merge branch 'master' into ERM-999

25164b9

adi-mat requested changes Sep 18, 2020

View reviewed changes

ERM-999

b09065e

ERM-999

35614c6

ERM-999

d684511

ERM-999

7296639

adi-mat added 3 commits September 21, 2020 16:42

Update LogsList.js

62d9949

Update en.json

2387d1a

Update en.json

3fa976b

adi-mat approved these changes Sep 21, 2020

View reviewed changes

adi-mat merged commit 4f1274f into folio-org:master Sep 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ERM-999: Add record/row identifiers into Local KB Admin log display #283

ERM-999: Add record/row identifiers into Local KB Admin log display #283

peterboehm commented Sep 18, 2020

id-jenkins commented Sep 18, 2020

id-jenkins commented Sep 18, 2020

adi-mat left a comment

adi-mat Sep 18, 2020

adi-mat Sep 18, 2020

id-jenkins commented Sep 21, 2020

id-jenkins commented Sep 21, 2020

id-jenkins commented Sep 21, 2020

peterboehm commented Sep 21, 2020

sonarcloud bot commented Sep 21, 2020

	recordDescriptor: ({ additionalInfo }) => {
	recordDescriptor: ({ additionalInfo = {} }) => {
	const { packageSource, packageSource, rowNumber, recordNumber } = additionalInfo;

ERM-999: Add record/row identifiers into Local KB Admin log display #283

ERM-999: Add record/row identifiers into Local KB Admin log display #283

Conversation

peterboehm commented Sep 18, 2020

id-jenkins commented Sep 18, 2020

id-jenkins commented Sep 18, 2020

adi-mat left a comment

Choose a reason for hiding this comment

adi-mat Sep 18, 2020

Choose a reason for hiding this comment

adi-mat Sep 18, 2020

Choose a reason for hiding this comment

id-jenkins commented Sep 21, 2020

id-jenkins commented Sep 21, 2020

id-jenkins commented Sep 21, 2020

peterboehm commented Sep 21, 2020

sonarcloud bot commented Sep 21, 2020