STUTL-30 replace json2csv #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`json2csv` was abandoned after v5. Updating to `@json2csv`, an ESM module, also required updating test infrastructure. Refs STUTL-30
|
Kudos, SonarCloud Quality Gate passed! |
JohnC-80
approved these changes
Mar 7, 2023
zburke
added a commit
that referenced
this pull request
Mar 13, 2023
This reverts commit b427cee. Maaaaaaybe this is the cause of failures in other repos, indicating that, across the board, jest needs to be updated to v29, and/or `@json2csv` needs to be added to `jest.config.js::transformIgnorePatterns`. I don't love either of those options, but I guess the "real" problem here is that `@folio` modules aren't transpiled upon distribution and that's allowing this issue to leak through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json2csvwas abandoned after v5. Updating to@json2csv, an ESM module, also required updating test infrastructure.Refs STUTL-30