Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERM-3183 Create agreement line form does not clear on "Save and creat… #1331

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

CalamityC
Copy link
Contributor

…e another"

  • add minimal delay between pushing the view page and opening the create page again

…e another"

* add minimal delay between pushing the view page and opening the create page again
Copy link

License CLA Stuck? (Developer should make sure that it is really stuck before clicking)

Copy link

github-actions bot commented Jun 26, 2024

Jest Unit Test Statistics

       1 files  ±0     154 suites  ±0   8m 7s ⏱️ ±0s
1 020 tests ±0  1 018 ✔️  - 2  0 💤 ±0  2 +2 
1 027 runs  ±0  1 025 ✔️  - 2  0 💤 ±0  2 +2 

For more details on these failures, see this check.

Results for commit a11d3f4. ± Comparison against base commit 7cab206.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 1, 2024

Jest Unit Test Results

    1 files  ±0    154 suites  ±0   3m 59s ⏱️ -1s
1 024 tests ±0  1 024 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 031 runs  ±0  1 031 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8c57ac9. ± Comparison against base commit a9f338c.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@EthanFreestone EthanFreestone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I approve this as a fix, but I reckon we should probably look into another way to ensure the form reinitialises...

Depends on if this needs backporting or not as to whether we merge here or close and reexamine

@CalamityC CalamityC marked this pull request as ready for review July 3, 2024 07:43
@CalamityC CalamityC requested a review from a team as a code owner July 3, 2024 07:43
Copy link
Collaborator

@EthanFreestone EthanFreestone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to use the form.reset mechanism we do elsewhere please?

From Create we need to reset the form, from edit we should redirect to "create" (which should clear the form for us)

@CalamityC CalamityC marked this pull request as draft July 3, 2024 15:43
Copy link

sonarcloud bot commented Jul 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants