Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update for stripes v9 #14

Merged
merged 7 commits into from
Dec 6, 2023
Merged

update for stripes v9 #14

merged 7 commits into from
Dec 6, 2023

Conversation

zburke
Copy link
Member

@zburke zburke commented Dec 4, 2023

@folio/stripes v9 updates including:

  • stripes v9 (duh)
  • stripes-cli v3
  • eslint-config-stripes v7
  • jest-config-stripes v2
  • node v18 (in CI)
  • purge remaining bigtest/karma cruft

@zburke
update for stripes v9
e700f98 
`@folio/stripes` v9 updates including:

* stripes v9 (duh)
* stripes-cli v3
* eslint-config-stripes v7
* jest-config-stripes v2
* node v18 (in CI)
* purge remaining bigtest/karma cruft
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited

Jest Unit Test Statistics

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit e700f98.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited

BigTest Unit Test Statistics

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit e700f98.

♻️ This comment has been updated with latest results.

@zburke
Copy link
Member Author

zburke commented Dec 4, 2023

@skomorokh, @ryandberger, @kaladay: True confessions: I changed all the things that off the top of my head needed changing but did not review this carefully. I'd be much obliged if any of you would point a stripes-cli install at this branch and confirm that it now does what it should.

skomorokh
skomorokh approved these changes Dec 4, 2023
View reviewed changes
Copy link

@skomorokh skomorokh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good quickness getting on top of this. I wonder if we should be in the habit of creating a new branch of this repo every release so one could create an app targetting a chosen release rather than whichever just froze?

@MikeTaylor
Copy link

Oh crap, another major release? This is a disease.

@zburke
Copy link
Member Author

zburke commented Dec 5, 2023

No, @MikeTaylor, v9 was Poppy. This PR is about bringing an out-of-date repo up-to-date with current stripes, not moving the stripes bar yet again.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zburke zburke merged commit 1db342e into master Dec 6, 2023
7 checks passed
@zburke zburke deleted the stripes-v9 branch December 6, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skomorokh skomorokh skomorokh approved these changes

@ryandberger ryandberger Awaiting requested review from ryandberger

@kaladay kaladay Awaiting requested review from kaladay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@zburke @MikeTaylor @skomorokh