Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIDATIMP-630: Refine an identifier matching for Instances #694

Merged
merged 7 commits into from
Sep 30, 2020

Conversation

mariia-aloshyna
Copy link
Contributor

Description

Data import users need to be able to match on a wide variety of identifiers in the Instance record. The current matching setup (Identifier and Identifier type as 2 separate matches) is cumbersome and may not work so it's needed to be able to match an identifying number from any MARC field to a particular identifier type number in an Instance (e.g. only match against OCLC number).

Approach

  • Add a new request to the manifest in MatchProfiles
  • Add fromResources field to an item in fieldsConfig that contains info about fields which should be retrieved from the resources
  • Rework getDropdownOptions function so options can be built from the resources

Ticket

UIDATIMP-630

Screenshot

identifiers_matching

@folio-org folio-org deleted a comment from sonarcloud bot Sep 29, 2020
Copy link
Contributor

@Vladyslav-Velytskyi Vladyslav-Velytskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

9.3% 9.3% Coverage
89.5% 89.5% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@mariia-aloshyna mariia-aloshyna merged commit b3216f2 into master Sep 30, 2020
@mariia-aloshyna mariia-aloshyna deleted the UIDATIMP-630 branch September 30, 2020 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants