Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIDATIMP-689: only import MatchingFieldsManager once #711

Merged
merged 1 commit into from
Oct 11, 2020
Merged

UIDATIMP-689: only import MatchingFieldsManager once #711

merged 1 commit into from
Oct 11, 2020

Conversation

zburke
Copy link
Member

@zburke zburke commented Oct 11, 2020 •
edited

MatchingFieldsManager was imported twice.

Fixes UIDATIMP-689

@zburke
only import MatchingFieldsManager once
a4a8917 
`MatchingFieldsManager` was imported twice.
@id-jenkins
Copy link 

yarn run v1.22.4
$ eslint .
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zburke zburke merged commit 2a9bae0 into master Oct 11, 2020
@zburke zburke deleted the remove-double-import branch October 11, 2020 03:47
@zburke zburke changed the title only import MatchingFieldsManager once UIDATIMP-689: only import MatchingFieldsManager once Oct 11, 2020
@zburke
Copy link
Member Author

zburke commented Oct 11, 2020

@IvanKryzhanovskyi, this error broke the reference environments. I filed UIDATIMP-690 as a follow-up story since I would have expected lint to catch this.

@zburke zburke mentioned this pull request Oct 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zburke @id-jenkins