UIIN-2371: Fixing tests due to changes in react-virtualized-auto-sizer.
#2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dmytro-Melnyshyn
changed the title
react-virtualized-auto-sizer.
|
Kudos, SonarCloud Quality Gate passed!
|
zburke
approved these changes
Mar 28, 2023
mkuklis
approved these changes
Mar 28, 2023
mkuklis
pushed a commit
that referenced
this pull request
Mar 28, 2023
OleksandrHladchenko1
added a commit
that referenced
this pull request
Apr 3, 2023
* Release v9.4.2 * UIIN-2364: Fix the query templates for searching by subject. (#2072) * UIIN-2347: Record count for "Subjects" doesn't match at browse and search result panes (#2068) * UIIN-2347: Changed a query for a subject request * UIIN-2347: Added a changelog * UIIN-2347: Fix tests * UIIN-2347: Changed a query for a subject filter request * UIIN-2351: Correctly reset facet state when icon next to the facet label is clicked (#2073) * Release v9.4.3 * UIIN-2371: Fixing tests due to changes in eact-virtualized-auto-sizer. (#2087) * UIIN-2343: Update success messages for ISRI * UIIN-2359: Retain searches and offsets in session storage, so they don't show up in other browser tabs, and clean them up after logging out. * Release v9.4.4 * delete unnecessary test * fix stripes-core path * Lokalise: updates (cherry picked from commit 3183389) * Release v9.4.5 * Update zh_CN.json * Update zh_CN.json * Update zh_CN.json --------- Co-authored-by: Michal Kuklis <michal.kuklis@gmail.com> Co-authored-by: Dmytro-Melnyshyn <77053927+Dmytro-Melnyshyn@users.noreply.github.com> Co-authored-by: daniil-patckin <124583895+daniil-patckin@users.noreply.github.com> Co-authored-by: Mariia Aloshyna <55138456+mariia-aloshyna@users.noreply.github.com> Co-authored-by: Dmytro-Melnyshyn <Dmytro_Melnyshyn@epam.com> Co-authored-by: FOLIO Translations Bot <38661258+folio-translations@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests are failing in apps due to a recent change in
react-virtualized-auto-sizer.We shouldn't mock
offsetHeightviamockOffsetSizebecause it is no longer relevant (43).Just mock
react-virtualized-auto-sizeritself.Issues
UIIN-2371
Approach
TODOS and Open Questions
Learning
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.