Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIQM 351: MARC Authority | Print Source record #468

Merged
merged 4 commits into from
Feb 17, 2023
Merged

Conversation

daniil-patckin
Copy link
Contributor

@daniil-patckin daniil-patckin commented Feb 15, 2023

Purpose

Remove the print button from this plugin to make it more flexible.
This changes affects:
folio-org/ui-inventory#1988
folio-org/ui-marc-authorities#242

Issues

UIQM-351

Need to merge simultaneously with folio-org/ui-inventory#1988

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@daniil-patckin daniil-patckin changed the title UI qm 351 UIQM 351: MARC Authority | Print Source record Feb 15, 2023
@github-actions
Copy link

github-actions bot commented Feb 15, 2023

Jest Unit Test Statistics

    1 files  ±0    33 suites  ±0   1m 28s ⏱️ -10s
253 tests  - 2  253 ✔️  - 2  0 💤 ±0  0 ±0 
254 runs   - 2  254 ✔️  - 2  0 💤 ±0  0 ±0 

Results for commit b177c61. ± Comparison against base commit b12c396.

♻️ This comment has been updated with latest results.

@daniil-patckin daniil-patckin marked this pull request as ready for review February 15, 2023 08:42
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@artem-blazhko artem-blazhko requested a review from a team February 17, 2023 12:22
@daniil-patckin daniil-patckin merged commit 1e491c9 into master Feb 17, 2023
@daniil-patckin daniil-patckin deleted the UIQM-351 branch February 17, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants