Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in GlyphInfo.js #66

Closed
liborm85 opened this issue Jan 10, 2017 · 2 comments
Closed

Bug in GlyphInfo.js #66

liborm85 opened this issue Jan 10, 2017 · 2 comments

Comments

@liborm85
Copy link
Contributor

Improvements made by commit b6d4653 in this file
https://github.com/devongovett/fontkit/blob/f84809aafbcc720fd4a912e8624b14193217032b/src/opentype/GlyphInfo.js#L37-L41 causing an error when is defined this._font.GDEF but this._font.GDEF.glyphClassDef is null.

Is throw error:
TypeError: Cannot read property 'version' of null

This bug was reported to pdfmake by @emanuelschuetze. Details in issue: bpampuch/pdfmake#818
@liborm85 liborm85 mentioned this issue Jan 10, 2017
Closed
liborm85 added a commit to bpampuch/pdfmake that referenced this issue Jan 15, 2017
@liborm85
temporary bugfix for fontkit version 1.5.2 - issue foliojs/fontkit#66
b43f46b
@achrist
Copy link
Contributor

achrist commented Mar 16, 2017

+1 for this. Also running into the same issue.

@achrist achrist mentioned this issue Mar 16, 2017
Merged
@devongovett
Copy link
Member

Fixed by #72. Released in v1.5.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@devongovett @achrist @liborm85