Fix subsetting CID fonts with no subrs #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to subset a CID-keyed CFF font with no subrs triggers a
TypeErrorin CFFSubset.js becausesubsetSubrs()attempts to check the.lengthof null. This PR addresses that by not attempting to subset subrs at all if they do not exist in the font.Fixes issue #42 (well, kinda but not really, the original issue that concerns is long gone but I found a related problem that should have been in a new issue). I didn't come up with this fix, credits go to @jahewson for pointing it out.