-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Universal Shaping Engine #54
Conversation
* Track whether glyphs are ligated separately from whether GDEF thinks the glyph is a ligature. * Propogate ligature properties in multiple substitutions. * Improve detection of mark ligatures
@behdad do you know of any open source fonts that use the rphf/pref features for USE scripts? Couldn't find any in Noto. Also, are there actually any scripts with arabic-style joining that aren't already handled by the arabic shaper? From looking at ArabicShaping.txt, it seems not. If this is the case, I may not need to implement that part of the spec for now. |
I don't know of. We tested with Windows fonts when implementing. Noto fonts have not been updated to USE yet; though, Khmer from noto-source might be: https://github.com/googlei18n/noto-source/tree/master/src I haven't built that one yet. @jungshik
MS routes N'Ko, and probably Mongolian and Phags Pa, through USE. We don't. |
Implemented rphf and pref feature behavior, though I don't have a font to test with at the moment. Made mark advance zeroing configurable by the shaper. Not implementing joining behavior because all scripts that need that are already handled by the Arabic shaper. I think this is pretty much ready to go! |
This starts the implementation of the Universal Shaping Engine. It borrows heavily from the implementation in Harfbuzz. Uses a state-machine compiler to generate a DFA that finds syllables to be reordered as defined by the USE spec.
Still a bunch to do, but it passes the Balinese test cases in text-rendering-tests. 😎
TODO: