Upgrade to support Unicode v10.0 #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, really sorry this got ignored for so long. The project is now written in ES6 instead of CoffeeScript, so this PR will need to be updated to support that. I'm gonna close it. Feel free to open a new PR. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates grapheme-breaker to support the new grapheme breaking rules in v10 of Unicode.
Note that as of the time of this PR, v10 has not officially been released yet, but is expected to be later in the month. It may be worthwhile holding off merging this PR until then, although anyone wanting support now can just use
@ov/grapheme-breakerin theirpackage.jsonin the meantime.There have been a lot of changes in Unicode since v8.0, including the addition of skin tone emoji modifiers and additional emoticons/characters. I tried to maintain the existing API in this package, but TBH the state machine ended up becoming quite complex and perhaps even brittle; rewriting using regexps may be possible, but likely at the expense of performance. That being said, this update passes all the unicode v10 tests as well as the emoji v5 tests.