Add browser friendly build #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
I'd like to avoid adding too many bespoke build scripts to these projects that we'll have to maintain. I'm proposing using Parcel for this, which will handle most of what we need automatically. See #21. |
I agree with that but there are still some work to do in parcel side (see notes in the parcel PR). In the mean time can we release with the custom build? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a browser build that does not depends on node "fs" module, so no need to run brfs when targeting browser environments
It also benefits node users with memory reduction since removes base64-js dependency and no intermediary base64 encoded data is loaded into memory
A "browser" entry is added to package.json and tests are adapted to run with both builds