Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on deprecated core-js (via babel-runtime) #1337

Closed
redstone99 opened this issue Jan 3, 2022 · 4 comments
Closed

Remove dependency on deprecated core-js (via babel-runtime) #1337

redstone99 opened this issue Jan 3, 2022 · 4 comments

Comments

@redstone99
Copy link

Pdfkit depends on core-js, which is no longer maintained and has a number of issues.
The chain is pdfkit -> fontkit -> babel-runtime -> core-js
It looks like babel-runtime also hasn't been updated in 2 years which is why I'm posting the feature request in pdfkit.
Maybe fontkit can be changed to not use babel-runtime? I'm not sure what the best fix is.
The concern with depending on un-maintained packages is some future security issue.

@redtogin
Copy link

redtogin commented Jan 3, 2022

I just came here to see if there is something about the core-js v2 dependency, as I get this warning from npm:

├─┬ careibu-pdf@1.0.0 -> ./shared/pdf
│ └─┬ pdfkit@0.13.0
│   └─┬ fontkit@1.8.1
│     └─┬ babel-runtime@6.26.0
│       └── core-js@2.6.12

npm WARN deprecated core-js@2.6.12:
core-js@<3.4 is no longer maintained and not recommended for usage due to the number of issues. 
Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. 
Please, upgrade your dependencies to the actual version of core-js.

@blikblum
Copy link
Member

blikblum commented Jan 3, 2022

There's nothing we can do in pdfkit. Its an issue with fontkit. There's already a PR in fontkit foliojs/fontkit#196

@blikblum blikblum closed this as completed Jan 3, 2022
@ghane
Copy link

ghane commented Sep 22, 2022

The PR has been accepted. Could we use the new release of fontkit in a new release of pdfkit, please?

@jacksonrayhamilton
Copy link

Yeah I’m seeing the deprecation notice as well. Looks like it has been a while and the fontkit update still hasn't made it to pdfkit.

Any blockers on that where you need help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants