-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on deprecated core-js (via babel-runtime) #1337
Comments
I just came here to see if there is something about the core-js v2 dependency, as I get this warning from npm:
|
There's nothing we can do in pdfkit. Its an issue with fontkit. There's already a PR in fontkit foliojs/fontkit#196 |
The PR has been accepted. Could we use the new release of |
Yeah I’m seeing the deprecation notice as well. Looks like it has been a while and the fontkit update still hasn't made it to pdfkit. Any blockers on that where you need help? |
Pdfkit depends on core-js, which is no longer maintained and has a number of issues.
The chain is pdfkit -> fontkit -> babel-runtime -> core-js
It looks like babel-runtime also hasn't been updated in 2 years which is why I'm posting the feature request in pdfkit.
Maybe fontkit can be changed to not use babel-runtime? I'm not sure what the best fix is.
The concern with depending on un-maintained packages is some future security issue.
The text was updated successfully, but these errors were encountered: