Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1486 fix newline items in lists #1487

Merged
merged 5 commits into from
Dec 22, 2023

Conversation

filecage
Copy link
Contributor

@filecage filecage commented Dec 20, 2023

What kind of change does this PR introduce?
Fixes #1486 by no longer using a newline character to separate list items, but actually print each list item in a single function and correctly respecting newlines of a list item.

Prior to this change, \n was used to separate list items, causing an unexpected number of bullet points when a list item contained a line break as well.

This PR also introduces a visual test for lists with different line break characters.

Checklist:

  • Unit Tests
  • Documentation (N/A)
  • Update CHANGELOG.md
  • Ready to be merged

@blikblum blikblum merged commit ebf404e into foliojs:master Dec 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Printing list item with line break fails with Unsupported Number: NaN
2 participants