Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty result returned when uploading portrait-oriented photo on iPad #54

Closed
dane-pi opened this issue Jan 21, 2016 · 9 comments
Closed

Comments

@dane-pi
Copy link

dane-pi commented Jan 21, 2016

Hi Everyone,

Before getting into the question, I just wanted to say thanks for the great work on this project. It's a very useful library that seems to be gaining much traction, can't wait to see where it goes!

I'm using the latest version - 1.0.3 - and when uploading a photo from an iPad I'm noticing an empty base64 string returned when calling:
croppie.result('canvas').then(function(result) { //code } );

After digging around, I'm seeing this effect only when (A) portrait-oriented photos have been uploaded by an iPad (B) the image has either been zoomed-out or panned so that its right and bottom borders are evenly-aligned (flush) with the right and bottom sides of the viewport. (test case images attached)

Has anyone else experienced this issue? I did see issue #31 , and have implemented the suggested solution without any luck.

Any thoughts or direction would be awesome, thanks again

Zoomed out

1-zoomedout

Panned, zoomed-in

2-panned

Results

2-result

@thedustinsmith
Copy link
Contributor

This kind of seems like it would be related to the exif orientation in #31. Let me look into it a little bit more, I just wanted to assure that we're looking into it.

@dane-pi
Copy link
Author

dane-pi commented Jan 25, 2016

Okay, thanks for looking into this.

@dane-pi
Copy link
Author

dane-pi commented Jan 29, 2016

Has anyone been able to replicate the issue - on the demo site or within your own project? Unsure how to resolve this, I'm open to any direction or feedback.

@thedustinsmith
Copy link
Contributor

I was able to replicate it given your steps. I'm working on a solution in my spare time. It seems we're going to have to offer an option to read the exif rotation.

@thedustinsmith
Copy link
Contributor

@dane-pi See the note here: #31 (comment)

I tried on the iPad with those changes and the problem seems to be fixed there. Does that fix it for you?

@thedustinsmith
Copy link
Contributor

@dane-pi You can install the beta version of croppie and see if it fixes your issues:

npm install croppie@2.0.0-beta1

@thedustinsmith
Copy link
Contributor

i think this is fixed in https://github.com/Foliotek/Croppie/releases/tag/v2.0.0.

My test case was resolved. Hopefully yours is too.

@dane-pi
Copy link
Author

dane-pi commented Feb 22, 2016

Hey - Sorry for the delay, yes it seems to be working. Thanks for your help!

@dws-arjun
Copy link

It says 'then', 'result' etc function not exist

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants