Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: setting merge_keywords to false breaks TodoTelescope #202

Closed
3 tasks done
j-barnak opened this issue May 20, 2023 · 2 comments · Fixed by #274 or #292
Closed
3 tasks done

bug: setting merge_keywords to false breaks TodoTelescope #202

j-barnak opened this issue May 20, 2023 · 2 comments · Fixed by #274 or #292
Labels
bug Something isn't working

Comments

@j-barnak
Copy link

Did you check docs and existing issues?

  • I have read all the todo-comments.nvim docs
  • I have searched the existing issues of todo-comments.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

NVIM v0.9.0

Operating system/version

Ubuntu 22.04.2 LTS

Describe the bug

If you set merge_keywords to false, it breaks the command TodoTelescope. I was trying to only include
FIXMEs in the highlights and Telescope, but I get presented with an error

Here's the configuration.

Steps To Reproduce

  1. Omit Keywords and only include a subset
  2. Run :TodoTelescope

Expected Behavior

I expect the Telescope results to only show FIXMEs

Repro

return {
  "folke/todo-comments.nvim",
  dependencies = {
    "nvim-lua/plenary.nvim",
    "nvim-telescope/telescope.nvim",
  },
  cmd = { "TodoTelescope" },
  event = { "BufReadPost", "BufNewFile" },
  config = true,
  opts = {
    signs = false,
    keywords = {
      FIX = {
        color = "#56B6C2",
        alt = { "FIXME", "BUG", "FIXIT", "ISSUE" },
      },
    },
    merge_keywords = false,
  },
  keys = {
    { "<leader>ft", "<cmd>TodoTelescope<cr>", desc = "Todo" },
  },
}
@j-barnak j-barnak added the bug Something isn't working label May 20, 2023
@dandyrow
Copy link

I have found this bug too. I thought there was something wrong as I installed the plugin but it wasn't working with Telescope. Disabled merge_keywords and it started working

b0ae989c added a commit to b0ae989c/todo-comments.nvim that referenced this issue Jun 11, 2024
@b0ae989c
Copy link
Contributor

This more of a missing config issue. You need to provided icon when you set merge_keywords = false. Otherwise Telescope entry maker will fail.

folke pushed a commit that referenced this issue Jun 11, 2024
folke pushed a commit that referenced this issue Jul 7, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.3.0](v1.2.0...v1.3.0)
(2024-07-07)


### Features

* added support for fzf-lua
([fe5a7c6](fe5a7c6))
* **fzf:** multiline by default
([8fdea2a](8fdea2a))
* **highlight:** allow extended highlighting patterns
([#185](#185))
([#255](#255))
([76c8fee](76c8fee))
* **highlight:** allow highlighting the full pattern
([#180](#180))
([ad775a7](ad775a7))


### Bug Fixes

* don't use tbl_flatten. Fixes
[#272](#272)
([9c104cf](9c104cf))
* **extension:** provide default icon
([#274](#274))
([7de4e85](7de4e85)),
closes [#202](#202)
* **highlight:** match to the end of length `#matched`
([#288](#288))
([a40fa7e](a40fa7e))
* **telecope:** icons highlight.
([#279](#279))
([4573f4f](4573f4f))
* ternary evaluation in setlist for opts.open
([#252](#252))
([c7a6a02](c7a6a02))
* **trouble:** compatibility with Trouble v3
([#286](#286))
([01b4599](01b4599))


### Reverts

* feat(highlight): allow highlighting the full pattern
([#180](#180))
([996d1a7](996d1a7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants